lkml.org 
[lkml]   [2009]   [Apr]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] x86/pci: make pci_mem_start to be aligned only -v4
On Sat, Apr 18, 2009 at 09:14:25PM +0200, Ingo Molnar wrote:
> This way we intentionally create a 'free physical address space'
> hole space that is the same as the rounding logic. No rounding
> needed anywhere - as all the remaining address space is well-rounded
> already. Plus we'd also _see_ all our rounding logic by looking at
> the '(guard)' entries.
>
> Or maybe there's some aspect of gap-rounding that cannot be
> expressed in such a static way?

My gut feeling is that you guys do overcomplicate a simple issue
which can be fixed with a one-liner like this:

pci_mem_start = pci_mem_start < 0xc0000000 ? : 0xc0000000;
This 0xc0000000 (3G) seems to be a pretty fundamental thing for certain
32-bit OS. ;-)
Ivan.


\
 
 \ /
  Last update: 2009-04-18 22:15    [from the cache]
©2003-2011 Jasper Spaans