lkml.org 
[lkml]   [2009]   [Apr]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
DateSat, 18 Apr 2009 12:28:51 -0700 (PDT)
FromLinus Torvalds <>
SubjectRe: [PATCH] arm: use include/gen for mach-types.h


On Sat, 18 Apr 2009, Sam Ravnborg wrote:
>
> diff --git a/include/gen/.gitignore b/include/gen/.gitignore
> new file mode 100644
> index 0000000..1e809fd
> --- /dev/null
> +++ b/include/gen/.gitignore
> @@ -0,0 +1,2 @@
> +# mach-types.h is used by arm
> +mach-types.h

I think this is bad.

The whole point of having 'include/gen' should be that _all_ files in that
directory should be generated. So it should be include/.gitignore that
just contains the pattern "gen/" and that's it.

That said, I also dislike "gen" as a name. To me, it is more likely to
mean "generation" in the sense of father/son/grandson than "generated".
Why not spell it out?

Linus


\
 
 \ /
  Last update: 2009-04-18 21:37    [from the cache]
©2003-2010