lkml.org 
[lkml]   [2009]   [Apr]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] arm: use include/gen for mach-types.h
    On Sat, Apr 18, 2009 at 08:17:14PM +0200, Sam Ravnborg wrote:
    > mach-types.h is a generated file.
    > As we no longer has a .gitignore file in asm-arm the risk
    > that somebody by accident commit mach-types.h is big.
    >
    > Avoid this by the introduction of include/gen/ to
    > hold this (and soon other) generated files.
    >
    > The patch includes two small cleanups to arch/arm/Makefile.
    > 1) delete stale comment
    > 2) combine two targets in one line and drop unused prerequisite
    >
    > The idea to introduce include/gen/ is originally from Al Viro.

    Umm...
    a) why CLEAN_FILES and not MRPROPER_FILES?
    b) I'd simply add include/gen to MRPROPER_FILES in the top-level
    Makefile.
    c) .gitignore in there ought to be simply *, if we want to create
    .gitignore there at all (we don't do that for include/config and the
    world doesn't end, after all).


    \
     
     \ /
      Last update: 2009-04-18 21:03    [W:0.021 / U:0.076 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site