Messages in this thread | | | Date | Sat, 18 Apr 2009 08:41:19 +0200 | From | Ingo Molnar <> | Subject | Re: [PATCH 0/5] fix bugs of x2apic/intr-remap |
| |
* Han, Weidong <weidong.han@intel.com> wrote:
> Ingo Molnar wrote: > > Note, there's a new compiler warning caused by your patches: > > > > arch/x86/kernel/apic/io_apic.c:2543: warning: 'eoi_ioapic_irq' > > defined but not used > > > > most likely by: > > > > 631dd75: x86, intr-remap: fix ack for interrupt remapping > > > > Ingo > > eoi_ioapic_irq is only used for remapped interrupt, so we should > define eoi_ioapic_irq and __eoi_ioapic_irq when #ifdef > CONFIG_INTR_REMAP.
Ok - please send a patch that fixes this.
Btw., it would be nice to reduce the number of #ifdef CONFIG_INTR_REMAP's in all .c files in general - or even eliminate them.
It might be feasible to move all the INTR_REMAP code into a separate .c file and only build it in the INTR_REMAP case. I have not tried to do that so i dont know - if the interfaces are too wide and unnatural to the rest of the ioapic code it might not improve the end result - but good layering generally does do the trick.
Ingo
| |