lkml.org 
[lkml]   [2009]   [Apr]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH 3/5] x86, intr-remap: enable interrupt remapping early
    From
    Date
    On Fri, 2009-04-17 at 07:13 -0700, Ingo Molnar wrote:
    > * Weidong Han <weidong.han@intel.com> wrote:
    >
    > > --- a/arch/x86/kernel/apic/apic.c
    > > +++ b/arch/x86/kernel/apic/apic.c
    > > @@ -118,6 +118,8 @@ static int x2apic_preenabled;
    > > static int disable_x2apic;
    > > static __init int setup_nox2apic(char *str)
    > > {
    > > + if (x2apic_enabled())
    > > + panic("Bios already enabled x2apic, can't enforce nox2apic");
    >
    > Could you please turn that into something like:

    I have couple of patches cleaning these up(including some warnings). I
    will post them shortly.

    > > +ir_failed:
    > > + if (x2apic_preenabled)
    > > + panic("x2apic enabled by bios. But IR enabling failed");
    >
    > What is the likelyhood that we can continue in compat mode? If
    > there's some chance, we should rather print a KERN_WARNING and
    > should try to continue. If IRQs are not coming we'll hang shortly
    > afterwards anyway.

    Typically only on high end platforms we will see x2apic enabled by BIOS
    before OS handover. And in these cases, BIOS should have already enabled
    interrupt-remapping in extended interrupt mode, before handing over
    control to OS. If the extended interrupt mode is set, HW will block the
    compatibility format interrupts anyway. And I think its better to panic
    rather than hanging at random places(depending on which interrupts are
    already in remapped format and which are not). This way, it will be easy
    for anyone to figure out what is happening.

    thanks,
    suresh



    \
     
     \ /
      Last update: 2009-04-18 01:47    [W:0.029 / U:0.032 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site