lkml.org 
[lkml]   [2009]   [Apr]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 3/5] tracing/events: add rcu locking around trace event prints

    On Fri, 17 Apr 2009, Jeremy Fitzhardinge wrote:

    > Theodore Tso wrote:
    > > I haven't been following all of the e-mail threads about the include
    > > hell problem; what are the issues, exactly? What's the problem with
    > > simply including <linux/rcuupdate.h>, and any needed prequisites in
    > > ftrace.h?
    >
    > I'm adding tracing support to paravirt.h, which in turn gets included in
    > various low-level arch/x86 headers. If it starts including other high-level
    > linux/ headers, we quickly get into deep #include recursion problems and
    > undefined symbols.

    I think our final solution of the:

    #ifdef CREATE_FOO_TRACE_POINTS
    #undef CREATE_FOO_TRACE_POINTS
    #include <trace/define_trace.h>
    #endif

    would fix this for us.

    -- Steve



    \
     
     \ /
      Last update: 2009-04-17 18:45    [W:3.374 / U:0.148 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site