Messages in this thread |  | | | Date | Fri, 17 Apr 2009 12:18:21 -0400 | | From | Theodore Tso <> | | Subject | Re: [PATCH 3/5] tracing/events: add rcu locking around trace event prints |
| |
On Fri, Apr 17, 2009 at 10:08:57AM -0400, Steven Rostedt wrote: > > Ted, is this patch still needed? > > I'm starting to have second thoughts on this patch because it may require > adding: #include <linux/rcupdate.h> in include/trace/ftrace.h. Jeremy has > been struggling with include hell with these files.
Well, I either need that or I need a way of having a TP_PRINTK_PRE() and TP_PRINTK_POST() so I can drop in the rcu_read_lock() and rcu_read_unlock() where needed. Or I need a TP_PRINTK_DELCARE() so I can declare the temporary buffer, and we can go down that route.
I haven't been following all of the e-mail threads about the include hell problem; what are the issues, exactly? What's the problem with simply including <linux/rcuupdate.h>, and any needed prequisites in ftrace.h?
- Ted
|  |