Messages in this thread | | | Date | Fri, 17 Apr 2009 15:01:21 +1000 | Subject | Re: [microblaze-uclinux] [PATCH 11/11] microblaze: Kconfig: Enable drivers for Microblaze | From | John Williams <> |
| |
On Thu, Apr 16, 2009 at 7:56 PM, <monstr@monstr.eu> wrote: > From: Michal Simek <monstr@monstr.eu> > > Signed-off-by: Michal Simek <monstr@monstr.eu>
ACK from a MicroBlaze perspective, but some other comments below:
A note more for the Xilinx PPC folks (ie Grant Likely):
Shouldn't some of these Kconfig depends for PPC be unified? We have:
> config XILINX_SYSACE > tristate "Xilinx SystemACE support" > - depends on 4xx > + depends on 4xx || MICROBLAZE
> config XILINX_HWICAP > tristate "Xilinx HWICAP Support" > - depends on XILINX_VIRTEX > + depends on XILINX_VIRTEX || MICROBLAZE
> config GPIO_XILINX > bool "Xilinx GPIO support" > - depends on PPC_OF > + depends on PPC_OF || MICROBLAZE > help > Say yes here to support the Xilinx FPGA GPIO device
Are these all really different options? PPC_OF? XILINX_VIRTEX? 4xx?
John -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |