lkml.org 
[lkml]   [2009]   [Apr]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH] usb driver for intellon based PLC like devolo dlan duo
Date
Am Freitag 17 April 2009 16:10:24 schrieb Peter Holik:

+static int intellon_rx_fixup(struct usbnet *dev, struct sk_buff *skb)
+{
+ int len;
+
+ if (unlikely(skb->len < INTELLON_HEADER_SIZE)) {
+ deverr(dev, "unexpected tiny rx frame");
+ return 0;
+ }
+
+ len = (skb->data[skb->len - 2] | (skb->data[skb->len - 1] << 8));

Please use a conversion function.

+ } else {
+ struct sk_buff *skb2;
+
+ skb2 = skb_copy_expand(skb,
+ INTELLON_HEADER_SIZE,
+ need_tail,
+ flags);
+ dev_kfree_skb_any(skb);
+ if (!skb2)
+ return skb2;

If you return NULL in an error case, write it so explicitely.

+ __skb_push(skb, INTELLON_HEADER_SIZE);
+
+ skb->data[0] = pack_len & 0xFF;
+ skb->data[1] = (pack_len & 0x700) >> 8;

Again, a conversion function is called for.

Regards
Oliver



\
 
 \ /
  Last update: 2009-04-17 16:43    [W:0.348 / U:0.068 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site