Messages in this thread | | | Date | Fri, 17 Apr 2009 09:17:37 +0900 | From | KAMEZAWA Hiroyuki <> | Subject | Re: [PATCH] Add file based RSS accounting for memory resource controller (v2) |
| |
On Fri, 17 Apr 2009 09:14:59 +0900 KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com> wrote:
> page_cgroup->mem_cgroup != try_get_mem_cgroup_from_mm(mm); in many many cases. > > For example, libc and /bin/*** is tend to be loaded into default cgroup at boot but > used by many cgroups. But mapcount of page caches for /bin/*** is 0 if not running. > > Then, File_Mapped can be greater than Cached easily if you use mm->owner. > > I can't estimate RSS in *my* cgroup if File_Mapped includes pages which is under > other cgroups. It's meaningless. > Especially, when Cached==0 but File_Mapped > 0, I think "oh, the kernel leaks somehing..hmm..." > > By useing page_cgroup->mem_cgroup, we can avoid above mess. > And, if pc->mem_cgroup is used, we can ignore "task move".
Thanks, -Kame
| |