lkml.org 
[lkml]   [2009]   [Apr]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] Documentation: Add "how to write a good patch summary" to SubmittingPatches
    On Thu, 16 Apr 2009, Theodore Ts'o wrote:

    > Unfortunately many patch submissions are arriving with painfully poor
    > patch descriptions. As a result of the discussion on LKML:
    >
    > http://lkml.org/lkml/2009/4/15/296
    >
    > explain how to submit a better patch description, in the (perhaps
    > vain) hope that maintainers won't end up having to rewrite the git
    > commit logs as often as they do today.
    >
    > Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
    > Cc: Ingo Molnar <mingo@elte.hu>
    > ---
    >

    Read through your diff. Looks good to me - nice additions.

    Feel free to add
    Acked-by: Jesper Juhl <jj@chaosbits.net>
    or
    Reviewed-by: Jesper Juhl <jj@chaosbits.net>
    if you like...

    Don't really know what's most appropriate here, but I like the patch.


    --
    Jesper Juhl <jj@chaosbits.net> http://www.chaosbits.net/
    Plain text mails only, please http://www.expita.com/nomime.html
    Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html



    \
     
     \ /
      Last update: 2009-04-16 22:29    [W:0.022 / U:30.084 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site