Messages in this thread |  | | | Date | Thu, 16 Apr 2009 18:53:43 +0200 | | From | Christoph Hellwig <> | | Subject | Re: [PATCH 0/8] [GIT PULL] TRACE_EVENT for modules |
On Tue, Apr 14, 2009 at 05:29:17PM -0400, Frank Ch. Eigler wrote: > Hi - > > On Tue, Apr 14, 2009 at 05:04:45PM -0400, Theodore Tso wrote: > > [...] > > One thing which I would really like is to avoid needing to drop the > > header file in include/trace/<subsystem.h>. > > > > The problem that I have with this is that for ext4, we need to access > > private data structures which are defined in header files in > > fs/ext4/*.h --- which we moved into fs/ext4 a long time ago [...] > > If the tracepoints/events expand to code that exposes those private > structures, then those structures are perhaps not quite so private any > more. That argues for moving those headers back under include/..., or > at least those type decls made reachable from the tracepoints.
They expose them to the TRACE_EVENT output format, which then pretty-prints them. They are still as private to the module as it gets.
|  |