Messages in this thread |  | | | Date | Thu, 16 Apr 2009 18:52:24 +0200 | | From | Christoph Hellwig <> | | Subject | Re: [PATCH 0/8] [GIT PULL] TRACE_EVENT for modules |
On Tue, Apr 14, 2009 at 05:04:45PM -0400, Theodore Tso wrote: > One thing which I would really like is to avoid needing to drop the > header file in include/trace/<subsystem.h>. > > The problem that I have with this is that for ext4, we need to access > private data structures which are defined in header files in > fs/ext4/*.h --- which we moved into fs/ext4 a long time ago at the > request of those who felt include/linux/* was getting rather > cluttered, and if a subsystem had header files which were only needed > by files for that particular subsystems, they should be moved out of > include/linux.
Same is true for XFS, or just about any other self-contained in a module subsystem I can think of. My current XFS trace events stuff includes tons of headers in the xfs header in include/trace and adds -Ifs/xfs to kernel/trace/Makefile. The latter should be gone by the new implementation compiling the tracing stubs into the module, but it's still not pretty.
|  |