lkml.org 
[lkml]   [2009]   [Apr]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [REGRESSION] threaded interrupt handler support breaks (some) irq handling on AVR32
Ben Nizette wrote:
> static irqreturn_t ads7846_irq(int irq, void *handle)
> {
> struct ads7846 *ts = handle;
> unsigned long flags;
>
> spin_lock_irqsave(&ts->lock, flags);
> if (likely(get_pendown_state(ts))) {
> if (!ts->irq_disabled) {
> /* The ARM do_simple_IRQ() dispatcher doesn't act
> * like the other dispatchers: it will report IRQs
> * even after they've been disabled. We work around
> * that here. (The "generic irq" framework may help...)
> */
> ts->irq_disabled = 1;
> disable_irq(ts->spi->irq);

Shouldn't that be disable_irq_nosync()?

Haavard


\
 
 \ /
  Last update: 2009-04-15 09:59    [W:0.107 / U:0.320 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site