lkml.org 
[lkml]   [2009]   [Apr]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: TRACE_BRANCH_PROFILING breaks gcc warnings

* Steven Rostedt <srostedt@redhat.com> wrote:

>
> On Wed, 2009-04-15 at 00:28 +0200, Johannes Berg wrote:
> > With TRACE_BRANCH_PROFILING enabled you get "dummy may be used
> > uninitialised" with code like the following (and gcc 4.3.3):
> >
> > void *dummy, *c;
> >
> > if (a && (dummy = b()))
> > c = dummy;
> >
> > Therefore, allyesconfig has become useless for looking at warnings.

There's an easy solution for that problem btw: you just have to
disable the branch tracer after allyesconfig. [ Or fix the compiler.
Or both ;-) ]

I'm also curious, how often do you do allyesconfig builds? I've
never seen you report one before. Have you started doing them
recently? How much time does it take on your system?

> > :(
>
> This has been mentioned before, and I've asked about sending a
> patch that would prevent TRACE_BRANCH_PROFILING from being
> selected with an allyesconfig.
>
> It is easy to do. I could make it a selection and not a boolean
> and it will not select it as default, even for allyes/modconfig
>
> Thoughts?

That's a good idea - please send a patch.

Ingo


\
 
 \ /
  Last update: 2009-04-15 09:41    [W:0.041 / U:0.492 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site