lkml.org 
[lkml]   [2009]   [Apr]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH resend 4/8] staging: agnx, fix fail paths in probe
    Date
    Return error on fail paths instead of 0.

    Signed-off-by: Jiri Slaby <jirislaby@gmail.com>
    ---
    drivers/staging/agnx/pci.c | 3 +++
    1 files changed, 3 insertions(+), 0 deletions(-)

    diff --git a/drivers/staging/agnx/pci.c b/drivers/staging/agnx/pci.c
    index 6d1b7c2..dd34b7e 100644
    --- a/drivers/staging/agnx/pci.c
    +++ b/drivers/staging/agnx/pci.c
    @@ -470,6 +470,7 @@ static int __devinit agnx_pci_probe(struct pci_dev *pdev,
    if (pci_set_dma_mask(pdev, DMA_BIT_MASK(32)) ||
    pci_set_consistent_dma_mask(pdev, DMA_BIT_MASK(32))) {
    dev_err(&pdev->dev, "no suitable DMA available\n");
    + err = -EIO;
    goto err_free_reg;
    }

    @@ -493,11 +494,13 @@ static int __devinit agnx_pci_probe(struct pci_dev *pdev,
    /* dev_dbg(&pdev->dev, "MEM1 mapped address is 0x%p\n", priv->ctl); */
    if (!priv->ctl) {
    dev_err(&pdev->dev, "can't map device memory\n");
    + err = -ENOMEM;
    goto err_free_dev;
    }
    priv->data = pci_iomap(pdev, 1, 0);
    if (!priv->data) {
    dev_err(&pdev->dev, "can't map device memory\n");
    + err = -ENOMEM;
    goto err_iounmap2;
    }

    --
    1.6.2


    \
     
     \ /
      Last update: 2009-04-15 08:33    [W:0.018 / U:31.332 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site