Messages in this thread |  | | | Date | Thu, 16 Apr 2009 00:40:17 +0200 | | From | Ingo Molnar <> | | Subject | Re: Fix quilt merge error in acpi-cpufreq.c |
| |
* Linus Torvalds <torvalds@linux-foundation.org> wrote:
> On Wed, 15 Apr 2009, Ingo Molnar wrote: > > > > Impact line exposes wrong patch structure: cleanup should never be > > mixed with fix. > > > > impact line somewhat atypical but correct - the patch is a cleanup > > but might affect user-space. > > > > Impact line is correct. > > > > Impact line is not duplicative of subject line. > > > > Impact line is incorrect (describes action not effect). > > > > Impact line is correct and appropriate. > > Bah. > > In _no_ case did the Impact: line actually say anything worth > saying, and it was there just for self-gratification.
As i said it in the mail, i actually used the impact line of commit 6b44003e5ca66 ("work_on_cpu(): rewrite it to create a kernel thread on demand") later on, when a regression was caused by that commit.
It is the third entry above.
Ingo
|  |