lkml.org 
[lkml]   [2009]   [Apr]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: Fix quilt merge error in acpi-cpufreq.c


On Wed, 15 Apr 2009, H. Peter Anvin wrote:
>
> "cleanup" is indeed the most common, as it is intended to signify a
> trivial but nonzero code change. Whether or not it's *correct* is
> another matter. "build fix" is valid and proper use: it tells that it
> fixes a compilation error, which succinctly communicates both the
> priority of the fix and how it needs to be validated.

Why would that be "proper use"?

Dammit, if the "build fix" is not obvious from the rest of the commit
message, there's something wrong.

And if it _is_ obvious, then the mechanical "Impact:" thing is pointless.

In other words - in neither case does it actually help anything at all.
It's only distracting noise.

Linus


\
 
 \ /
  Last update: 2009-04-15 21:51    [from the cache]
©2003-2014 Jasper Spaans. Advertise on this site