lkml.org 
[lkml]   [2009]   [Apr]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 1/3] net: introduce a list of device addresses dev_addr_list
    Wed, Apr 15, 2009 at 12:13:57PM CEST, kaber@trash.net wrote:
    > David Miller wrote:
    >> From: Eric Dumazet <dada1@cosmosbay.com>
    >> Date: Wed, 15 Apr 2009 11:27:50 +0200
    >>
    >>> Since you obviously need a write lock here to be sure following
    >>> can be done by one cpu only.
    >>>
    >>> You have same problem all over this patch.
    >>
    >> RTNL semaphore is held across all modification operations.
    >
    > If this will also be used for multicast lists, changes can happen
    > (IPv6) without the RTNL.

    Ok, but for dev_addr_X() functions the RTNL mutex is sufficient so I see no
    point of adding another lock here. When the multicast handling functions will be
    implemented to use netdev_hw_addr and it's layer, then we need to use update
    lock in dev_multicast_X.


    \
     
     \ /
      Last update: 2009-04-15 16:47    [W:0.045 / U:89.588 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site