Messages in this thread | | | Date | Wed, 15 Apr 2009 13:09:37 +0200 | From | Ingo Molnar <> | Subject | Re: [PATCH v2 2/4] ftrace: introduce workqueue_handler_exit tracepoint and rename workqueue_execution to workqueue_handler_entry |
| |
* Oleg Nesterov <oleg@redhat.com> wrote:
> > > lock_map_acquire(&lockdep_map); > > > + trace_workqueue_handler_entry(cwq->thread, work); > > > f(work); > > > + trace_workqueue_handler_exit(cwq->thread, work); > > This doesn't look right. We must not use "work" after f(work). > work->func() can kfree its work.
We can use it as long as we use it as a 'cookie' - i.e. an identifier for visualization/statistics, but dont actually dereference it, right?
Ingo
| |