Messages in this thread | | | Date | Wed, 15 Apr 2009 10:29:24 +0200 | From | Jiri Pirko <> | Subject | Re: [PATCH 1/3] net: introduce a list of device addresses dev_addr_list |
| |
Wed, Apr 15, 2009 at 10:26:04AM CEST, lizf@cn.fujitsu.com wrote: >> +static int __hw_addr_add_ii(struct list_head *list, unsigned char *addr, >> + int addr_len, int ignore_index) >> +{ >> + struct netdev_hw_addr *ha; >> + int i = 0; >> + >> + if (addr_len > MAX_ADDR_LEN) >> + return -EINVAL; >> + >> + rcu_read_lock(); >> + list_for_each_entry_rcu(ha, list, list) { >> + if (i++ != ignore_index && >> + !memcmp(ha->addr, addr, addr_len)) { >> + ha->refcount++; >> + return 0; > >missing rcu_read_unlock() ? > Sure! Thanks... >> + } >> + } >> + rcu_read_unlock();
| |