Messages in this thread | | | From | David Howells <> | Subject | Re: [PATCH] FRV: Fix the section attribute on UP DECLARE_PER_CPU() | Date | Tue, 14 Apr 2009 18:57:45 +0100 |
| |
Linus Torvalds <torvalds@linux-foundation.org> wrote:
> We should have the DECLARE_PER_CPU() #defines next to the DEFINE_PER_CPU > ones, rather than somewhere else. > > So moving the logic to <asm-generic/percpu.h> is wrong - make it all be in > <linux/percpu.h> so that they can be maintained together.
Agreed, it would be nice. However, x86 requires it to be declared in the middle of asm/percpu.h (ie: in asm-generic/percpu.h). I'm trying to sort it out, but it's like trying to juggle hyperdimensional spaghetti:-/ How much header file overhaul do you wish to indulge in? And can I split some headers into separate headers for declarations and inline functions?
David
| |