Messages in this thread |  | | | Date | Tue, 14 Apr 2009 09:57:58 -0700 (PDT) | | From | Linus Torvalds <> | | Subject | Re: [PATCH] FRV: Fix the section attribute on UP DECLARE_PER_CPU() |
| |
On Tue, 14 Apr 2009, David Howells wrote: > > To fix this, DECLARE_PER_CPU() should simply interpose the same section > attribute as does DEFINE_PER_CPU(). However, this is made slightly more > complex by virtue of the fact that there are several variants on DEFINE, so > these need to be matched by variants of DECLARE.
This needs to be fixed.
We should have the DECLARE_PER_CPU() #defines next to the DEFINE_PER_CPU ones, rather than somewhere else.
So moving the logic to <asm-generic/percpu.h> is wrong - make it all be in <linux/percpu.h> so that they can be maintained together.
Linus
|  |