Messages in this thread | | | Date | Tue, 14 Apr 2009 18:50:52 +0200 | From | Ingo Molnar <> | Subject | Re: [PATCH -tip] x86: cpu_debug.c prepare report if files are inappropriate or CPU is not supported |
| |
* Jaswinder Singh Rajput <jaswinder@kernel.org> wrote:
> + if (!per_cpu(cpu_modelflag, cpu))
hm, on a second look - the whole cpu_model / cpu_modelflag business in arch/x86/kernel/cpu/cpu_debug.c looks over-complicated and broken. You encode it into a 'modelflag':
per_cpu(cpu_model, cpu) = ((cpui->x86_vendor << 16) | (cpui->x86 << 8) | (cpui->x86_model));
just to decode it later on:
flag = per_cpu(cpu_model, cpu);
switch (flag >> 16) {
That does not make much sense. Please use a proper boot_cpu_data.x86_vendor switch() statement, ok?
Ingo
| |