lkml.org 
[lkml]   [2009]   [Apr]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH 14/17] scsi: replace custom rq mapping with blk_rq_map_kern_sgl()
From
On Mon, 13 Apr 2009 18:38:23 +0900
Tejun Heo <tj@kernel.org> wrote:

> FUJITA Tomonori wrote:
> >> I thought that was agreed and done? What is left to do for that to go
> >> in.
> >
> > I've converted all the users (sg, st, osst). Nothing is left. So we
> > don't need this.
>
> Yeah, pulled it. Okay, so we can postpone diddling with request
> mapping for now. I'll re-post fixes only from this and the previous
> patchset and proceed with other patchsets.

To be honest, I don't think that we can clean up the block
mapping. For example, blk_rq_map_kern_prealloc() in your patchset
doesn't look cleanup to me. It's just moving a hack from ide to the
block (well, I have to admit that I did the same thing when I
converted sg/st/osst...).

We can't have good API with insane users. I don't want to ask this
publicly but don't we have any chance to merge the old ide code and
libata?


\
 
 \ /
  Last update: 2009-04-13 12:11    [W:1.383 / U:0.344 seconds]
©2003-2011 Jasper Spaans. Advertise on this site