lkml.org 
[lkml]   [2009]   [Apr]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] parport: Use the PCI IRQ if offered
On Tue, Apr 07, 2009 at 03:30:57PM +0100, Alan Cox wrote:
> PCI parallel port devices can IRQ share so we should stop them hogging the
> line and making a mess on modern PC systems. We know the sharing side works
> as the PCMCIA driver has shared the parallel port IRQ for some time.
>
> Signed-off-by: Alan Cox <alan@lxorguk.ukuu.org.uk>

> +extern struct parport *parport_pc_probe_port(unsigned long base,
> + unsigned long base_hi,
> + int irq, int dma,
> + struct device *dev,
> + int irqflags);
> +extern void parport_pc_unregister_port(struct parport *p);
>

You missed a bunch of uses of parport_pc_probe_port and broke the build
on powerpc, sparc, parisc, and probably several more.

regards, Kyle


\
 
 \ /
  Last update: 2009-04-13 06:49    [W:0.040 / U:0.100 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site