lkml.org 
[lkml]   [2009]   [Apr]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH]Silencing warning: 'host' may be used uninitialized in this function
Marin Mitov wrote:
> On Friday 10 April 2009 01:38:28 am Jeff Garzik wrote:
>> Marin Mitov wrote:
>>> Hi all,
>>>
>>> I do not know if that is worth the effort, but...
>>>
>>> Silencing: warning: 'host' may be used uninitialized in this function
>>> It is a false positive.
>>>
>>> The patch is against 2.6.30-rc1, but should apply to 2.6.29(.1) too.
>>>
>>> Signed-off-by: Marin Mitov mitov@issp.bas.bg
>>> ================================================
>>> --- a/drivers/ata/sata_via.c 2009-04-05 22:59:26.000000000 +0300
>>> +++ b/drivers/ata/sata_via.c 2009-04-06 00:07:25.000000000 +0300
>>> @@ -566,7 +566,7 @@
>>> static int printed_version;
>>> unsigned int i;
>>> int rc;
>>> - struct ata_host *host;
>>> + struct ata_host *host = host;
>>> int board_id = (int) ent->driver_data;
>>> const unsigned *bar_sizes;
>> we use the uninitialized_var() macro for false positives.
>>
>> Jeff
>>
>
> Well, changed and resubmitted.
>
> Marin Mitov
>
> Silencing: " warning: 'host' may be used uninitialized in this function"
>
> The patch is against 2.6.30-rc1, but should apply to 2.6.29(.1) too.
>
> Signed-off-by: Marin Mitov mitov@issp.bas.bg
> ================================================
> --- a/drivers/ata/sata_via.c 2009-04-05 22:59:26.000000000 +0300
> +++ b/drivers/ata/sata_via.c 2009-04-06 00:07:25.000000000 +0300
> @@ -566,7 +566,7 @@
> static int printed_version;
> unsigned int i;
> int rc;
> - struct ata_host *host;
> + struct ata_host *uninitialized_var(host);
> int board_id = (int) ent->driver_data;
> const unsigned *bar_sizes;

I did this a slightly different way... I went ahead and simply
initialized it.

Jeff






\
 
 \ /
  Last update: 2009-04-13 10:15    [W:0.049 / U:0.228 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site