Messages in this thread | | | Date | Tue, 14 Apr 2009 02:09:34 +0200 | From | Ingo Molnar <> | Subject | Re: [tip:sched/urgent] sched: Print sched_group::__cpu_power in sched_domain_debug |
| |
* Tony Luck <tony.luck@intel.com> wrote:
> > --- a/kernel/sched.c > > +++ b/kernel/sched.c > > @@ -6963,7 +6963,8 @@ static int sched_domain_debug_one(struct sched_domain *sd, int cpu, int level, > > cpumask_or(groupmask, groupmask, sched_group_cpus(group)); > > > > cpulist_scnprintf(str, sizeof(str), sched_group_cpus(group)); > > - printk(KERN_CONT " %s", str); > > + printk(KERN_CONT " %s (__cpu_power = %d)", str, > > + group->__cpu_power); > > This has added a lot of clutter to the console log during boot > (especially on large systems). > > Here is the start of the diff output comparing old and new console > messages on a 16 cpu machine: > > 77c77 > < groups: 0 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 > --- > > groups: 0 (__cpu_power = 1024) 1 (__cpu_power = 1024) 2 (__cpu_power = 1024) 3 (__cpu_power = 1024) 4 (__cpu_power = 1024) 5 (__cpu_power = 1024) 6 (__cpu_power = 1024) 7 (__cpu_power = 1024) 8 ( > __cpu_power = 1024) 9 (__cpu_power = 1024) 10 (__cpu_power = 1024) 11 > (__cpu_power = 1024) 12 (__cpu_power = 1024) 13 (__cpu_power = 1024) > 14 (__cpu_power = 1024) 15 (__cpu_power = 1024) > 80c80
indeed ...
I think we should skip the printout in the default (power==1024) case. Gautham?
Ingo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |