lkml.org 
[lkml]   [2009]   [Apr]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: Re: [PATCH 1/1] tracing, workqueuetrace: Make workqueuetracepoints use TRACE_EVENT macro
Date
* From: "Ingo Molnar" <mingo@elte.hu>
> * Zhaolei <zhaolei@cn.fujitsu.com> wrote:
>
>> It it because I use similar format with other TRACE_EVENT
>> definition. Actually, I don't know why we need to add prefix and
>> postfix TABs, and is it necessary to use tab to make alignment for
>> each fields.
>
> The __array() entry is a bit special - i wouldnt worry much about
> it, please ignore the checkpatch warning in this case - or remove
> the prefix tab.
Hello, Ingo

Thanks for your teach.

I think remove the prefix tab only(but remain postfix) make code looks
a bit ugly. I prefer to remain both tabs.
It is to say I will not modify tabs in this patch.

Thanks
Zhaolei

>
> The alignment of the fields are useful visually: all the field names
> are enumerated in a vertical row and are easy to see at a glance.
> The postfix tabs are nice because they move the non-C-syntax closing
> ')' out of the line of sight. The prefix tabs are useful for a
> similar reason.
>
> Ingo
>
>
\
 
 \ /
  Last update: 2009-04-13 06:11    [from the cache]
©2003-2011 Jasper Spaans