lkml.org 
[lkml]   [2009]   [Apr]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: mmotm 2009-04-10-02-21 uploaded - forkbombed by work_for_cpu


On Mon, 13 Apr 2009, Andrew Morton wrote:
>
> static void drv_write(struct drv_cmd *cmd)
> {
> - unsigned int i;
> + unsigned int cpu;
>
> - for_each_cpu(i, cmd->mask) {
> - work_on_cpu(i, do_drv_write, cmd);
> - }
> + for_each_cpu(cpu, cmd->mask)
> + smp_call_function_single(cpu, do_drv_write, cmd, 1);

Ok, that's just -wrong-.

Doesn't anybody else see anything odd in doing

for_each_cpu(cpu, cmd->mask)
smp_call_function_single(cpu, ..);

and react to it?

IOW, why not just do

smp_call_function_many(cmd->mask, do_drv_write, cmd, 1);

here?

Linus


\
 
 \ /
  Last update: 2009-04-13 19:55    [W:0.266 / U:1.088 seconds]
©2003-2014 Jasper Spaans. Advertise on this site