lkml.org 
[lkml]   [2009]   [Apr]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH] kobject: kzfree object in _release function
    From
    Hi Greg,

    On Mon, Apr 13, 2009 at 7:31 PM, Greg KH <greg@kroah.com> wrote:
    > On Sun, Apr 12, 2009 at 12:16:26AM +0800, tom.leiming@gmail.com wrote:
    >> From: Ming Lei <tom.leiming@gmail.com>
    >>
    >> It helps to troubleshoot the __buggy__ case, in which
    >> unreferenced objects are still accessed, using kzfree
    >> to free objects safely in _release function.
    >>
    >> Signed-off-by: Ming Lei <tom.leiming@gmail.com>
    >> ---
    >>  lib/kobject.c |    4 ++--
    >>  1 files changed, 2 insertions(+), 2 deletions(-)
    >>
    >> diff --git a/lib/kobject.c b/lib/kobject.c
    >> index a6dec32..cb5a562 100644
    >> --- a/lib/kobject.c
    >> +++ b/lib/kobject.c
    >> @@ -597,7 +597,7 @@ void kobject_put(struct kobject *kobj)
    >>  static void dynamic_kobj_release(struct kobject *kobj)
    >>  {
    >>       pr_debug("kobject: (%p): %s\n", kobj, __func__);
    >> -     kfree(kobj);
    >> +     kzfree(kobj);
    >>  }
    >>
    >>  static struct kobj_type dynamic_kobj_ktype = {
    >> @@ -762,7 +762,7 @@ static void kset_release(struct kobject *kobj)
    >>       struct kset *kset = container_of(kobj, struct kset, kobj);
    >>       pr_debug("kobject: '%s' (%p): %s\n",
    >>                kobject_name(kobj), kobj, __func__);
    >> -     kfree(kset);
    >> +     kzfree(kset);
    >
    >
    > What about slab-poisoning?  Shouldn't we just rely on that instead?

    Yes, you should. kzfree() strictly for cases where _correctness_ of
    the program requires it (i.e. security concerns).
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2009-04-13 18:41    [W:2.505 / U:0.680 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site