lkml.org 
[lkml]   [2009]   [Apr]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: Re: [PATCH 1/1] tracing, workqueuetrace: Make workqueue tracepoints use TRACE_EVENT macro

* Zhaolei <zhaolei@cn.fujitsu.com> wrote:

> It it because I use similar format with other TRACE_EVENT
> definition. Actually, I don't know why we need to add prefix and
> postfix TABs, and is it necessary to use tab to make alignment for
> each fields.

The __array() entry is a bit special - i wouldnt worry much about
it, please ignore the checkpatch warning in this case - or remove
the prefix tab.

The alignment of the fields are useful visually: all the field names
are enumerated in a vertical row and are easy to see at a glance.
The postfix tabs are nice because they move the non-C-syntax closing
')' out of the line of sight. The prefix tabs are useful for a
similar reason.

Ingo


\
 
 \ /
  Last update: 2009-04-13 05:59    [W:0.230 / U:0.128 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site