lkml.org 
[lkml]   [2009]   [Apr]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[PATCH 2/3] tracing/filters: disallow newline as delimeter
    I guess because user input is often ended with '\n' (like "echo xxx"),
    thus '\n' is used as a delimeter besides ' ' ? But we can just strip
    tailing spaces.

    One of the effects of this patch, is fixing this inconsistency:

    # echo -n 'parent_comm ==' > filter
    bash: echo: write error: Invalid argument
    # echo 'parent_comm ==' > filter
    # cat filter
    parent_comm ==
    Signed-off-by: Li Zefan <lizf@cn.fujitsu.com>
    ---
    kernel/trace/trace_events_filter.c | 4 +++-
    1 files changed, 3 insertions(+), 1 deletions(-)
    diff --git a/kernel/trace/trace_events_filter.c b/kernel/trace/trace_events_filter.c
    index a63f965..9ef35c1 100644
    --- a/kernel/trace/trace_events_filter.c
    +++ b/kernel/trace/trace_events_filter.c
    @@ -362,7 +362,9 @@ int filter_parse(char **pbuf, struct filter_pred *pred)
    char *tok, *val_str = NULL;
    int tok_n = 0;

    - while ((tok = strsep(pbuf, " \n"))) {
    + strstrip(*pbuf);
    +
    + while ((tok = strsep(pbuf, " "))) {
    if (tok_n == 0) {
    if (!strcmp(tok, "0")) {
    pred->clear = 1;
    --
    1.5.4.rc3


    \
     
     \ /
      Last update: 2009-04-13 04:41    [from the cache]
    ©2003-2014 Jasper Spaans. hosted at Digital Ocean