lkml.org 
[lkml]   [2009]   [Apr]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] [3/4] x86: MCE: Improve mce_get_rip
Andi Kleen wrote:
>> Following is a proposal version. Maybe dividing it into 2 pieces, function
>> improvement and MSR definition, would be a good idea.
>
> I don't think we need the full MSR definitions right now, at least
> I don't have any plans to support them. After all current CPUs
> don't.
>
> The rest looks good.

Thanks.

I still believe that using MSR which only available on 32bit from 64bit
code is not right thing. However this is not logical bug, and adding
definition is not suitable for 2.6.30. I'd like to defer the MSR part
to the next time.

BTW, since this patch is "Improve", I think you need to clarify why you
bind it into the "bugfix" patch set for 2.6.30. If there are known bug,
please describe about it.


Thanks,
H.Seto



\
 
 \ /
  Last update: 2009-04-10 06:41    [W:0.072 / U:0.084 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site