lkml.org 
[lkml]   [2009]   [Apr]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 06/30] netns: don't get/put old netns on CLONE_NEWNET
Quoting Alexey Dobriyan (adobriyan@gmail.com):
> copy_net_ns() doesn't copy anything, it creates fresh netns,
> so get/put of old netns is unneeded.
>
> Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>

Acked-by: Serge Hallyn <serue@us.ibm.com>

> ---
>
> net/core/net_namespace.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> --- a/net/core/net_namespace.c
> +++ b/net/core/net_namespace.c
> @@ -120,10 +120,8 @@ struct net *copy_net_ns(unsigned long flags, struct net *old_net)
> struct net *new_net = NULL;
> int err;
>
> - get_net(old_net);
> -
> if (!(flags & CLONE_NEWNET))
> - return old_net;
> + return get_net(old_net);
>
> err = -ENOMEM;
> new_net = net_alloc();
> @@ -142,7 +140,6 @@ struct net *copy_net_ns(unsigned long flags, struct net *old_net)
> if (err)
> goto out_free;
> out:
> - put_net(old_net);
> return new_net;
>
> out_free:


\
 
 \ /
  Last update: 2009-04-11 00:41    [W:0.029 / U:0.648 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site