Messages in this thread | | | Date | Fri, 10 Apr 2009 17:29:16 -0500 | From | "Serge E. Hallyn" <> | Subject | Re: [PATCH 04/30] ipcns: add create_ipc_ns() |
| |
Quoting Alexey Dobriyan (adobriyan@gmail.com): > clone_ipc_ns() is misnamed, it doesn't clone anything and doesn't uses passed > parameter. Rename it. > > create_ipc_ns() will be used by C/R to create ipcns on restart. > > Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
Acked-by: Serge Hallyn <serue@us.ibm.com>
> --- > > include/linux/ipc_namespace.h | 1 + > ipc/namespace.c | 9 ++------- > 2 files changed, 3 insertions(+), 7 deletions(-) > > --- a/include/linux/ipc_namespace.h > +++ b/include/linux/ipc_namespace.h > @@ -97,6 +97,7 @@ static inline int mq_init_ns(struct ipc_namespace *ns) { return 0; } > > #if defined(CONFIG_IPC_NS) > extern void free_ipc_ns(struct ipc_namespace *ns); > +struct ipc_namespace *create_ipc_ns(void); > extern struct ipc_namespace *copy_ipcs(unsigned long flags, > struct ipc_namespace *ns); > extern void free_ipcs(struct ipc_namespace *ns, struct ipc_ids *ids, > --- a/ipc/namespace.c > +++ b/ipc/namespace.c > @@ -14,7 +14,7 @@ > > #include "util.h" > > -static struct ipc_namespace *clone_ipc_ns(struct ipc_namespace *old_ns) > +struct ipc_namespace *create_ipc_ns(void) > { > struct ipc_namespace *ns; > int err; > @@ -48,14 +48,9 @@ static struct ipc_namespace *clone_ipc_ns(struct ipc_namespace *old_ns) > > struct ipc_namespace *copy_ipcs(unsigned long flags, struct ipc_namespace *ns) > { > - struct ipc_namespace *new_ns; > - > if (!(flags & CLONE_NEWIPC)) > return get_ipc_ns(ns); > - > - new_ns = clone_ipc_ns(ns); > - > - return new_ns; > + return create_ipc_ns(); > } > > /*
| |