lkml.org 
[lkml]   [2009]   [Apr]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/14] score - New architecure port to SunplusCT S+CORE
On Wed, 8 Apr 2009 15:21:00 +0800 liqin.chen@sunplusct.com wrote:

> From: Chen Liqin <liqin.chen@sunplusct.com>
>
> asm/asm.h, asm/atomic.h, asm/auxvec.h, asm/bitops.h, asm/bug.h,
> asm/bugs.h, asm/byteorder.h, asm/cacheflush.h, asm/cache.h
> and asm/checksum.h for the score architecture.
>
>
> ...
>
> +#define PG_dcache_dirty PG_arch_1
> +
> +#define Page_dcache_dirty(page) \
> + test_bit(PG_dcache_dirty, &(page)->flags)
> +#define SetPageDcacheDirty(page) \
> + set_bit(PG_dcache_dirty, &(page)->flags)
> +#define ClearPageDcacheDirty(page) \
> + clear_bit(PG_dcache_dirty, &(page)->flags)

We have ugly macros in include/linux/page-flags.h which expand a page
flag out into its accessors, with standardised naming: TESTSCFLAG,
CLEARPAGEFLAG_NOOP, etc.

It would be best of those were reused here.

>
> ...
>


\
 
 \ /
  Last update: 2009-04-10 08:19    [W:0.028 / U:0.184 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site