lkml.org 
[lkml]   [2009]   [Apr]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [git-pull -tip] x86: declaration patches
    On Fri, 10 Apr 2009, Jaswinder Singh Rajput wrote:

    > On Fri, 2009-04-10 at 18:51 +0200, Thomas Gleixner wrote:
    > > On Fri, 10 Apr 2009, Jaswinder Singh Rajput wrote:
    > > > #endif /* CONFIG_X86_32 */
    > > > diff --git a/arch/x86/kernel/apic/io_apic.c b/arch/x86/kernel/apic/io_apic.c
    > > > index 8499000..d1bac67 100644
    > > > --- a/arch/x86/kernel/apic/io_apic.c
    > > > +++ b/arch/x86/kernel/apic/io_apic.c
    > > > @@ -59,6 +59,7 @@
    > > > #include <asm/setup.h>
    > > > #include <asm/irq_remapping.h>
    > > > #include <asm/hpet.h>
    > > > +#include <asm/hw_irq.h> /* smp_irq_move_cleanup_interrupt */
    > >
    > > Can we please avoid these useless comments all over the place ?
    > >
    >
    > I kept these intentionally because few of these declarations I have
    > already fixed earlier.
    > For example during process.c unification work developers forget to
    > include and fix syscalls.h :

    And how does such a comment help not to forget anything ? It's useless
    information and just irritating to read like all end of line comments.

    Thanks,

    tglx


    \
     
     \ /
      Last update: 2009-04-10 20:17    [W:0.023 / U:59.572 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site