lkml.org 
[lkml]   [2009]   [Apr]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    SubjectRe: [git-pull -tip] x86: declaration patches
    From
    Date
    On Fri, 2009-04-10 at 18:51 +0200, Thomas Gleixner wrote:
    > On Fri, 10 Apr 2009, Jaswinder Singh Rajput wrote:
    > > #endif /* CONFIG_X86_32 */
    > > diff --git a/arch/x86/kernel/apic/io_apic.c b/arch/x86/kernel/apic/io_apic.c
    > > index 8499000..d1bac67 100644
    > > --- a/arch/x86/kernel/apic/io_apic.c
    > > +++ b/arch/x86/kernel/apic/io_apic.c
    > > @@ -59,6 +59,7 @@
    > > #include <asm/setup.h>
    > > #include <asm/irq_remapping.h>
    > > #include <asm/hpet.h>
    > > +#include <asm/hw_irq.h> /* smp_irq_move_cleanup_interrupt */
    >
    > Can we please avoid these useless comments all over the place ?
    >

    I kept these intentionally because few of these declarations I have
    already fixed earlier.
    For example during process.c unification work developers forget to
    include and fix syscalls.h :

    http://git.kernel.org/?p=linux/kernel/git/x86/linux-2.6-tip.git;a=commit;h=389d1fb11e5f2a16b5e34c547756f0c4dec641f7

    Thats why I did:

    diff --git a/arch/x86/kernel/process.c b/arch/x86/kernel/process.c
    index 1d71442..4d397ce 100644
    --- a/arch/x86/kernel/process.c
    +++ b/arch/x86/kernel/process.c
    @@ -15,6 +15,7 @@
    #include <asm/uaccess.h>
    #include <asm/i387.h>
    #include <asm/ds.h>
    +#include <asm/syscalls.h> /* sys_fork, sys_vfork */

    unsigned long idle_halt;
    EXPORT_SYMBOL(idle_halt);
    Ingo, do you also think we need to remove these comments.

    --
    JSR




    \
     
     \ /
      Last update: 2009-04-10 19:25    [W:0.025 / U:29.768 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site