lkml.org 
[lkml]   [2009]   [Apr]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 03/30] ipcns: remove useless get/put while CLONE_NEWIPC
Quoting Alexey Dobriyan (adobriyan@gmail.com):
> copy_ipcs() doesn't actually copy anything. If new ipcns is created,
> it's created from scratch, in this case get/put on old ipcns isn't needed.
>
> Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>

Yeah, I like this change just for the diffstat.

Acked-by: Serge Hallyn <serue@us.ibm.com>

How about breaking these out from the c/r set?

thanks,
-serge

> ---
>
> ipc/namespace.c | 6 +-----
> 1 file changed, 1 insertion(+), 5 deletions(-)
>
> --- a/ipc/namespace.c
> +++ b/ipc/namespace.c
> @@ -50,15 +50,11 @@ struct ipc_namespace *copy_ipcs(unsigned long flags, struct ipc_namespace *ns)
> {
> struct ipc_namespace *new_ns;
>
> - BUG_ON(!ns);
> - get_ipc_ns(ns);
> -
> if (!(flags & CLONE_NEWIPC))
> - return ns;
> + return get_ipc_ns(ns);
>
> new_ns = clone_ipc_ns(ns);
>
> - put_ipc_ns(ns);
> return new_ns;
> }


\
 
 \ /
  Last update: 2009-04-10 17:23    [W:0.054 / U:1.948 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site