lkml.org 
[lkml]   [2009]   [Apr]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] x86: percpu_to_op() misses memory and flags clobbers
    Eric Dumazet wrote:
    > +#define percpu_inc(var) percpu_to_op0("inc", per_cpu__##var)
    > +#define percpu_dec(var) percpu_to_op0("dec", per_cpu__##var)
    >

    There's probably not a lot of value in this. The Intel and AMD
    optimisation guides tend to deprecate inc/dec in favour of using
    add/sub, because the former can cause pipeline stalls due to its partial
    flags update.

    J


    \
     
     \ /
      Last update: 2009-04-01 20:11    [W:0.021 / U:0.436 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site