Messages in this thread |  | | | Date | Thu, 2 Apr 2009 10:13:23 +1700 | | Subject | Re: [PATCH 2/2] toshiba-acpi: Support TOS1900-type devices | | From | Azael Avalos <> |
| |
On Thu, Apr 2, 2009 at 10:07 AM, Matthew Garrett <mjg59@srcf.ucam.org> wrote: > On Thu, Apr 02, 2009 at 10:03:05AM +1700, Azael Avalos wrote: >> On Thu, Apr 2, 2009 at 9:53 AM, Matthew Garrett <mjg59@srcf.ucam.org> wrote: >> > Yes, you shouldn't be reading directly from TOHK at any point. It seems >> > to be a purely internal variable - I'm fairly sure that the INFO method >> > is the only one that should be called on event generation. >> >> Well, on the patches sent to the omnibook module I was polling TOHK directly, >> it is until now that I realized that I can poll the events via INFO >> method, that is, >> if I enable TECF first via method \\_SB.PCI0.LPCB.EC0.NTFY > > Mm. None of the TOS1900 DSDTs I have here have TECF or NTFY methods, so > again that doesn't sound like the right way of driving them. Does the > ENAB method not do this?
At least not in my model, the ENAB method is empty, heres a snippet of the DSDT:
Method (ENAB, 0, NotSerialized) { } Method (INFO, 0, NotSerialized) { If (TECF) { Store (Zero, TECF) Store (^^PCI0.LPCB.EC0.TOHK, Local0) Store (Zero, ^^PCI0.LPCB.EC0.TOHK) } Else { Store (Zero, Local0) } Return (Local0) } And above scope _SB you can find
Method (NTFY, 0, NotSerialized) { Store (One, ^^^^VALZ.TECF) Notify (VALZ, 0x80) Return (0xAA) } Saludos Azael
-- -- El mundo apesta y vosotros apestais tambien --
|  |