lkml.org 
[lkml]   [2009]   [Apr]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 18/24] mxser: remove tty_port_tty_get from mxser_check_modem_status
    Date
    From: Jiri Slaby <jirislaby@gmail.com>

    mxser_check_modem_status is called with tty parameter, so the
    reference should be increased by callers already -- for ioctl
    syscall it is held whole time gap since open to close, for
    interrupt, the reference count is increased in the irq handler.

    There is no tty_kref_put in that function, so this also fixes
    a refcounting bug.

    Signed-off-by: Jiri Slaby <jirislaby@gmail.com>
    Signed-off-by: Alan Cox <alan@lxorguk.ukuu.org.uk>
    ---

    drivers/char/mxser.c | 1 -
    1 files changed, 0 insertions(+), 1 deletions(-)


    diff --git a/drivers/char/mxser.c b/drivers/char/mxser.c
    index 402c9f2..a420e8d 100644
    --- a/drivers/char/mxser.c
    +++ b/drivers/char/mxser.c
    @@ -820,7 +820,6 @@ static void mxser_check_modem_status(struct tty_struct *tty,
    wake_up_interruptible(&port->port.open_wait);
    }

    - tty = tty_port_tty_get(&port->port);
    if (port->port.flags & ASYNC_CTS_FLOW) {
    if (tty->hw_stopped) {
    if (status & UART_MSR_CTS) {


    \
     
     \ /
      Last update: 2009-04-01 16:15    [W:0.018 / U:152.648 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site