Messages in this thread Patch in this message | | | From | Alan Cox <> | Subject | [PATCH 18/24] mxser: remove tty_port_tty_get from mxser_check_modem_status | Date | Wed, 01 Apr 2009 15:06:57 +0100 |
| |
From: Jiri Slaby <jirislaby@gmail.com>
mxser_check_modem_status is called with tty parameter, so the reference should be increased by callers already -- for ioctl syscall it is held whole time gap since open to close, for interrupt, the reference count is increased in the irq handler.
There is no tty_kref_put in that function, so this also fixes a refcounting bug.
Signed-off-by: Jiri Slaby <jirislaby@gmail.com> Signed-off-by: Alan Cox <alan@lxorguk.ukuu.org.uk> ---
drivers/char/mxser.c | 1 - 1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/drivers/char/mxser.c b/drivers/char/mxser.c index 402c9f2..a420e8d 100644 --- a/drivers/char/mxser.c +++ b/drivers/char/mxser.c @@ -820,7 +820,6 @@ static void mxser_check_modem_status(struct tty_struct *tty, wake_up_interruptible(&port->port.open_wait); } - tty = tty_port_tty_get(&port->port); if (port->port.flags & ASYNC_CTS_FLOW) { if (tty->hw_stopped) { if (status & UART_MSR_CTS) {
| |