lkml.org 
[lkml]   [2009]   [Apr]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [patch 0/21] x86, ptrace, bts, hw-branch-tracer: fixes and cleanups

    * Metzger, Markus T <markus.t.metzger@intel.com> wrote:

    > >-----Original Message-----
    > >From: Ingo Molnar [mailto:mingo@elte.hu]
    > >Sent: Wednesday, April 01, 2009 1:46 PM
    > >To: Metzger, Markus T
    >
    >
    > >> >> The first 5 patches apply to .29 with the small preparation patch below.
    > >> >
    > >> >Tried to review these patches.
    > >> >
    > >> >As I said, I don't understand ds.c, but I _think_ these changes are good.
    > >> >
    > >> >I only have a couple of really minor nitpicks...
    > >>
    > >> Thanks for your review!
    > >> I will address the nitpicks in separate patches, if that's OK with everyone.
    > >
    > >Please dont forget to propagate Oleg's Reviewed-by (or Acked-by)
    > >tags into the commits.
    > >
    > >> Regarding bisecting, I split the patches to attract reviewers to
    > >> the smaller parts rather than scare them off with one big patch.
    > >>
    > >> I hope that the bisecting tool can cope with broken builds between
    > >> patches.
    > >
    > >It cannot, and even if it did we dont want a single intentionally
    > >broken bisection point in the kernel. Please do small patches that
    > >build fine at each step. We've got more than 100,000 bisectable
    > >commits in the kernel to look at. If you think it's not possible in
    > >a specific case then please describe the situation to us so that we
    > >can suggest a solution.
    >
    > I can resend the series with fewer but bigger patches that compile
    > OK.
    >
    > I'm currently using quilt to manage patches. I use git to get the
    > sources, but that's it. I send all the patches manually.
    >
    > You mentioned in another email that I should use "git
    > format-patch" and "git send-email" and that I should propagate
    > Oleg's acks into the commit logs.
    >
    > Is there a way to do this with quilt, as well? Could you point me
    > to some getting-started documentation?

    Maybe "quilt mail" does it correctly but i have not checked.

    Ingo


    \
     
     \ /
      Last update: 2009-04-01 15:23    [W:0.024 / U:152.668 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site