lkml.org 
[lkml]   [2009]   [Apr]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
DateWed, 1 Apr 2009 14:47:09 +0200
FromJens Axboe <>
SubjectRe: [PATCH 4/8] bio: actually inline inline bvecs into bio
On Wed, Apr 01 2009, Tejun Heo wrote:
> Impact: cleanup
>
> BIO_INLINE_VECS bvecs are inlined into bio to avoid bvec allocation
> for small transfers. This was achieved by declaring zero sized bvec
> array at the end of bio and allocating bio with extra bytes at the
> end. As BIO_INLINE_VECS is constant, there is no reason to do this
> allocation trick. This patch simply defines BIO_INLINE_VECS sized
> bvec array at the end. This will help fixing bio_kmalloc().

I don't like this, it's much nicer to do it with a zero sized array. If
you don't need a bio_vec, then you don't consume the extra space. I
guess for that to really work, we'd need one more slab and mempool
though. At least for non-stack bio's. I also fear that direct uses of
->bi_inline_vecs[] will then crop up, making it harder to go back.

--
Jens Axboe



\
 
 \ /
  Last update: 2009-04-01 14:51    [from the cache]
©2003-2010