Messages in this thread | | | Date | Wed, 1 Apr 2009 21:18:43 +0900 | Subject | Re: [PATCH 2/8] block: fix SG_IO vector request data length handling | From | FUJITA Tomonori <> |
| |
On Wed, 1 Apr 2009 13:50:58 +0200 Jens Axboe <jens.axboe@oracle.com> wrote:
> On Wed, Apr 01 2009, FUJITA Tomonori wrote: > > On Wed, 1 Apr 2009 20:04:38 +0900 > > Tejun Heo <tj@kernel.org> wrote: > > > > > Impact: fix SG_IO behavior such that it matches the documentation > > > > > > SG_IO howto says that if ->dxfer_len and sum of iovec disagress, the > > > shorter one wins. However, the current implementation returns -EINVAL > > > for such cases. Trim iovc if it's longer than ->dxfer_len. > > > > Is that description about sg's SG_IO? > > The more important question is what sg.c actually does, that's more > important than the documentation.
Do you think that Doug is a person who makes such mistake? ;)
Seems that sg worked as the howto says. But I think that I broke it when I converted sg to use the block layer. I'll fix it soon.
About this patch, as we know, there are lots of subtle differences between sg's SG_IO and the block's. I'm not sure that it's a good idea to change the behavior of the block's SG_IO.
| |