Messages in this thread | | | Subject | Re: [PATCH] Free the temporary vfsmount created in bdev_cache_init() | From | Catalin Marinas <> | Date | Wed, 01 Apr 2009 13:12:08 +0100 |
| |
On Wed, 2009-04-01 at 12:49 +0100, Al Viro wrote: > On Wed, Apr 01, 2009 at 12:07:37PM +0100, Catalin Marinas wrote: > > The vfsmount structure allocated in this function (the bd_mnt local > > variable) is only used to obtain the blockdev_superblock and there are > > no other references to it. This structure can be safely freed (and > > prevent kmemleak from reporting it). > > NAK. This kind of kludges is simply not worth doing. Store the > pointer to vfsmount into a static-in-file variable if you want > to get kmemleak to STFU.
That's how it used to be until commit c2acf7b9 made bd_mnt a local variable. Rather than reverting part of this commit, I can add a kmemleak_ignore() call to shut it up.
-- Catalin
| |