lkml.org 
[lkml]   [2009]   [Apr]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] Free the temporary vfsmount created in bdev_cache_init()
From
Date
On Wed, 2009-04-01 at 12:49 +0100, Al Viro wrote:
> On Wed, Apr 01, 2009 at 12:07:37PM +0100, Catalin Marinas wrote:
> > The vfsmount structure allocated in this function (the bd_mnt local
> > variable) is only used to obtain the blockdev_superblock and there are
> > no other references to it. This structure can be safely freed (and
> > prevent kmemleak from reporting it).
>
> NAK. This kind of kludges is simply not worth doing. Store the
> pointer to vfsmount into a static-in-file variable if you want
> to get kmemleak to STFU.

That's how it used to be until commit c2acf7b9 made bd_mnt a local
variable. Rather than reverting part of this commit, I can add a
kmemleak_ignore() call to shut it up.

--
Catalin



\
 
 \ /
  Last update: 2009-04-01 14:15    [W:0.036 / U:0.148 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site