lkml.org 
[lkml]   [2009]   [Mar]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] powerpc 4xx: DDR0_14[REDUC] decoded incorrectly
    On Mon, Mar 09, 2009 at 06:21:36PM +0200, Mikhail Zolotaryov wrote:
    > Hi,
    >
    > according to the PPC440EPx Embedded Processor User Manual (rev 1.14)
    > DDR0_14[REDUC] bit has the following meaning:
    >
    > REDUC - Enable the half data path feature of the controller
    > 0 = Standard operation using full 64/72-bit memory bus
    > 1 = Memory data path width is 32/40 bits
    >
    > However, "1" is decoded as 64 bit (8 byte), "0" - as 32 bit (4 byte) bus
    > by the kernel code. My understanding is this is not correct - patch
    > attached.

    You are missing the Signed-off-by tag that is needed.

    Aside from that, I'm curious if you found this just through inspection, or
    if you actually had a problem because of it. Your fix seems correct, yet
    I've had no problems with my boards at all.

    josh


    \
     
     \ /
      Last update: 2009-03-09 18:15    [W:0.028 / U:0.016 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site