Messages in this thread | | | Date | Sun, 8 Mar 2009 15:11:21 +0100 | From | Pierre Ossman <> | Subject | Re: [PATCH 05/13] sdhci: Add support for card-detection polling |
| |
On Wed, 4 Mar 2009 20:49:17 +0300 Anton Vorontsov <avorontsov@ru.mvista.com> wrote:
> On Sat, Feb 21, 2009 at 04:58:21PM +0100, Pierre Ossman wrote: > > Just modify the if-clause and > > things will work. > > That would look horrid... > > if ((!(host->quirks & SDHCI_QUIRK_BROKEN_CARD_DETECTION) && > !(sdhci_readl(host, SDHCI_PRESENT_STATE) & > SDHCI_CARD_PRESENT)) || > (host->flags & SDHCI_DEVICE_DEAD)) { >
There are worse ones in that code, but I see your point. :)
> > Might want to add a comment also to make it more obvious what the > > if-clause does. > > Let's try to avoid the if-clause above? How about this: >
Looks ok.
> @@ -1096,6 +1099,7 @@ out: > static void sdhci_request(struct mmc_host *mmc, struct mmc_request *mrq) > { > struct sdhci_host *host; > + bool present; > unsigned long flags; > > host = mmc_priv(mmc);
Can we use bool in the kernel?
Rgds -- -- Pierre Ossman
WARNING: This correspondence is being monitored by the Swedish government. Make sure your server uses encryption for SMTP traffic and consider using PGP for end-to-end encryption. [unhandled content-type:application/pgp-signature] | |