lkml.org 
[lkml]   [2009]   [Mar]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 01/10] ide: add ->dma_clear method and remove ->dma_timeout one
Bartlomiej Zolnierkiewicz wrote:

> All custom ->dma_timeout implementations call the generic one thus it is
> possible to have only an optional method for resetting DMA engine instead:
>
> * Add ->dma_clear method and convert hpt366, pdc202xx_old and sl82c105
> host drivers to use it.
>
> * Always use ide_dma_timeout() in ide_dma_timeout_retry() and remove
> ->dma_timeout method.
>
> * Make ide_dma_timeout() static.
>
> There should be no functional changes caused by this patch.
>
> Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
>

Acked-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>

> Index: b/include/linux/ide.h
> ===================================================================
> --- a/include/linux/ide.h
> +++ b/include/linux/ide.h
> @@ -715,8 +715,9 @@ struct ide_dma_ops {
> int (*dma_end)(struct ide_drive_s *);
> int (*dma_test_irq)(struct ide_drive_s *);
> void (*dma_lost_irq)(struct ide_drive_s *);
> + /* below ones are optional */
> int (*dma_timer_expiry)(struct ide_drive_s *);
> - void (*dma_timeout)(struct ide_drive_s *);
> + void (*dma_clear)(struct ide_drive_s *);
> /*
> * The following method is optional and only required to be
>

Perhaps worth removing the words about method being optional now...

> * implemented for the SFF-8038i compatible controllers.
>

MBR, Sergei



\
 
 \ /
  Last update: 2009-03-08 23:19    [from the cache]
©2003-2014 Jasper Spaans. Advertise on this site